Add playground RIR tab with raw and ssa processed RIR #2096
Conversation
idavis
requested review from
billti,
sezna,
swernli and
minestarks
as code owners
| e, | ||
| ))] | ||
| })?; | ||
| Ok(vec![raw.to_string(), ssa.to_string()]) |
There was a problem hiding this comment.
Why convert the tuple to a vec here? You could just return the tuple. Were you fighting JavaScript?
There was a problem hiding this comment.
Yes, I wanted to return a tuple, but the wasm bindings wouldn't let me, so instead of having to turn a tuple into vec, I just kept it in a vec to start
There was a problem hiding this comment.
We also may be returning more instances of RIR to show pass steps which would be a vec eventually.
| @@ -220,6 +220,21 @@ pub fn get_hir( | |||
| Ok(package.to_string()) | |||
| } | |||
|
|
|||
| #[wasm_bindgen] | |||
| pub fn get_rir(program: ProgramConfig) -> Result<Vec<String>, String> { | |||
There was a problem hiding this comment.
It's an extra step, but for readability and type checking, please define a struct (which will be converted to a JS object) for the return type instead of a "tuple" (or JS array). Just makes it so much easier to use from the JS side.
Currently we use the serializable_type! macro. generate_docs/IDocFile in this file is an example you can follow. (It is a bit verbose, I plan to improve it in the future, but right now that's the pattern we use all over this module).
There was a problem hiding this comment.
I avoided that as it is likely that there will be additional RIR returned such that we have a vec of RIR representing compilation/optimization steps so we can view the iteration of the compilation. We have other examples where we are wrapping complex types and returning arrays of them. It seemed overkill to do so when the value is just a string.
|
@idavis just noticed that the RIR tab doesn't show errors like the QIR tab does. RIR will just continue to show the last successful result which can be frustrating. Maybe you forgot to wire up the error handling somehow? |
No description provided.